Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming SamplingDecision options #1297

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Renaming SamplingDecision options #1297

merged 2 commits into from
Sep 21, 2020

Conversation

eddynaka
Copy link
Contributor

Fixes #1255.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team September 21, 2020 23:05
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1297 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
- Coverage   79.17%   79.12%   -0.05%     
==========================================
  Files         215      215              
  Lines        6176     6176              
==========================================
- Hits         4890     4887       -3     
- Misses       1286     1289       +3     
Impacted Files Coverage Δ
src/OpenTelemetry/Trace/ActivitySourceAdapter.cs 92.42% <100.00%> (ø)
src/OpenTelemetry/Trace/AlwaysOffSampler.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Trace/AlwaysOnSampler.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Trace/ParentBasedSampler.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Trace/SamplingResult.cs 54.54% <100.00%> (ø)
src/OpenTelemetry/Trace/TracerProviderSdk.cs 94.95% <100.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 61.76% <0.00%> (-2.95%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
....Prometheus/PrometheusExporterMetricsHttpServer.cs 74.50% <0.00%> (-1.97%) ⬇️

@cijothomas cijothomas merged commit f1ebf05 into open-telemetry:master Sep 21, 2020
@eddynaka eddynaka deleted the feature/renaming-enum branch October 17, 2020 00:08
@paulomf paulomf mentioned this pull request Sep 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent SamplingDecision Names
2 participants